home: Show organization name and icon atop main menu#1313
home: Show organization name and icon atop main menu#1313chimnayajith wants to merge 3 commits intozulip:mainfrom
Conversation
a130711 to
865b141
Compare
|
Thanks @chimnayajith for picking this up! These changes look pretty clean, so I'm hopeful this can be finished and merged without too much further work. And the feature is something we've heard requests for from users. So although we're generally focusing on launch issues now, and this issue is post-launch, I think this PR can be one of the exceptions which we continue work on. One thing it'll need before we give it a detailed review, though: some tests are failing, which you'll need to fix. |
865b141 to
47917ec
Compare
47917ec to
8ba5c37
Compare
|
@gnprice Fixed the failing tests. Please take a look. |
|
Great, thanks. The next stage for this PR will be maintainer review: Maintainers will prioritize reviewing PRs for launch issues, so this one might sit idle for a while at times. Similarly, on your end please prioritize launch issues. The thing you can do to help expedite this PR is to occasionally reread it while bearing in mind feedback you've gotten on other PRs, and try to spot places where similar feedback would apply. Then you can revise it accordingly, which will simplify later review. |
Pull Request
Description
This PR implements the feature to display the current organization’s name and icon at the top of the main menu, as per the design in Figma here.
The organization name (
realmName) and icon (realmIcon) are fetched from the initial snapshot and stored inPerAccountStore.The "Organizations" button leads to the
ChooseAccountPage.Related Issues
Screenshots